Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker refactor #1581

Closed
wants to merge 7 commits into from
Closed

docker refactor #1581

wants to merge 7 commits into from

Conversation

rossja
Copy link
Contributor

@rossja rossja commented Oct 16, 2023

Description

Refactored the Docker env to break images out based on cloud (still contains a combined env for all the tools in one). Also changes to a python base container (still ubuntu based).

This is what's been at rossja/ncc-scoutsuite for the last 8 months (the combined env one anyway). I've just pushed the separate containers for the clouds there as well.

This will be a "breaking" change in that the containers are named differently (instead of just scoutsuite, they will be scoutsuite-{cloud} -- so scoutsuite-aws for AWS tooling, etc. To avoid issues for now, I've been creating the combined image and naming that ncc-scoutsuite for compatibility.

There's also a base image that doesn't contain any of the cloud SDKs, just the scoutsuite code. That's scoutsuite-base.

Make sure the PR is against the develop branch (see Contributing).

Make sure to set the corresponding milestone in the PR.

Please include a summary of the change(s) and which issue(s) it addresses. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@rossja
Copy link
Contributor Author

rossja commented Oct 16, 2023

just noticed this PR got sub'd against master, sorry. resubmitting against dev.

@rossja rossja closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant